Greptile Summary

This PR fixes a regression where transient network failures (e.g., losing internet) were treated identically to auth errors, causing Linear to disconnect unnecessarily. The fix introduces a null-sentinel lastVerifiedDisplayName field and an isAuthFailure helper to distinguish permanent auth errors from transient ones — keeping the connection alive through temporary failures.

• P1 regression in fetchViewerDisplayName: The original code used org?.name (optional chaining) but the extracted helper uses organization.name — if viewer.organization resolves to null, this throws a TypeError that would cause saveToken to reject a valid token with an obscure error.

Confidence Score: 4/5

Safe to merge after fixing the dropped optional chaining on organization?.name.

One P1 regression: the extracted fetchViewerDisplayName helper dropped the original org?.name optional chaining, which could throw a TypeError if viewer.organization resolves to null — causing saveToken to reject a valid token. No P0 issues; the core transient-failure logic is sound.

src/main/core/linear/linear-connection-service.ts — specifically line 124 in fetchViewerDisplayName

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[checkConnection called] --> B[getStoredToken]
    B -->|no token| C[lastVerifiedDisplayName = null\nreturn connected: false]
    B -->|token found| D[fetchViewerDisplayName]
    D -->|success| E[lastVerifiedDisplayName = displayName\nreturn connected: true]
    D -->|throws| F{isAuthFailure?}
    F -->|yes| G[lastVerifiedDisplayName = null\nreturn connected: false + error]
    F -->|no transient error| H{lastVerifiedDisplayName === null?}
    H -->|yes never verified| I[return connected: false]
    H -->|no was previously verified| J[log.warn\nreturn connected: true\ndisplayName: lastVerifiedDisplayName]

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
src/main/core/linear/linear-connection-service.ts:124
The original call sites used `org?.name` (optional chaining), but the extracted helper removed it. If `viewer.organization` ever resolves to `null` or `undefined`, `organization.name` will throw a `TypeError`. In `saveToken` this would cause a valid token to be rejected with an obscure error message; in `checkConnection` it would be treated as a transient failure. Adding `?.` restores the original defensive behaviour.

```suggestion
    return organization?.name ?? viewer.displayName ?? undefined;
```

_{Reviews (2): Last reviewed commit: "fix(linear): handle verified connections..." | Re-trigger Greptile}

@greptile review